-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Appveyor testing #3115
Add Appveyor testing #3115
Conversation
@parkr: do we also need to run tests with |
You might need administrator access for that, right?
What's wrong with the badge? 😕
ideally, yes. The only reason we have that is so that travis can parallelize builds for us. If you leave that env var unset, it should just run both. |
Nope, it should work fine without it... I'll leave that after we get the tests to pass and we enable caching.
I need the code from the AppVeyor settings. I don't have access there...
OK, I'll leave it out for the time being. So to summarize, can we get the tests to pass first? I can rebase my branch from master frequently if needed. |
So @parkr, can you share the vanilla badge code from the project you set up? BTW, you have disabled it it seems. |
For the master branch:
So here's my dilemma. I want AppVeyor to run, but I don't want it to override the TravisCI status. I wrote into GitHub Support to see if we could show both of them. Is there another way to report? |
PR updated with the new code.
That I don't know :/ Maybe @FeodorFitsner can shed some light. |
@FeodorFitsner: It seems AppVeyor is getting:
https://ci.appveyor.com/project/XhmikosR/jekyll/build/job/l1lt8vsndkpji0yy If this isn't something you could take of upstream, I guess I will resort into trying something from http://ga.be/blog/2013/10/02/fixing-rubygems-ssl-issues-certificate-verify-failed/ |
Take a look: http://stackoverflow.com/questions/10246023/bundle-install-fails-with-ssl-certificate-verification-error |
Well, last time I tried BTW @parkr can we get some Windows stuff in? Or maybe just rename your parkr account to jekyll? We can always enable caching later if you want to merge this sooner. |
Not sure what this means?
No idea how to do this. AppVeyor's UX is a bit opaque to me at the moment. |
I mean some tests fixes so that Windows tests pass. https://ci.appveyor.com/account https://ci.appveyor.com/team <- you can add me here. |
Ok, added you to the team. |
Thanks. I added |
@FeodorFitsner: unfortunately, https://ci.appveyor.com/project/XhmikosR/jekyll/build/job/0g0hu8fcyaxai7lt |
Right now I really don't have a clue where to dig next. Have you tried that on different versions of Ruby? |
@FeodorFitsner: yes and it fails. Note that locally I don't have any of those issues. So my guess is that you will need to update your Ruby installations. |
you mean re-installing from scratch? |
No, I mean upgrading them. Or maybe just the certificates would work. |
You can experiment by installing a clean Ruby 1.9 using the following script:
|
@FeodorFitsner: I tried that and it fails too. https://ci.appveyor.com/project/XhmikosR/jekyll/build/59 So my guess is the certificates are to blame. Still, I wonder, how come no one else has complained to you about this. |
Do you use "unstable" build worker image or default one? -Feodor On Thu, Nov 27, 2014 at 12:24 AM, XhmikosR notifications@github.com
|
Since I have no idea about that, my guess is what the default is. |
OK, I've got it working! Look at the results: Secret recipe is settings updated CA certs: https://github.com/FeodorFitsner/ruby-misc-tests/blob/master/appveyor.yml#L2-L3 |
Thanks! But can't we have this applied in AppVeyor itself? @parkr: so, do you think we should merge this or fix the Windows tests that fail first? Personally, I'd rather go with the later as long as someone can fix the tests, so that I enable caching and try |
I'd like to get it all passing first. I might also prefer AppVeyor support on jekyll/integration-tests so we don't have to fiddle with the unit tests to much. |
I'm not familiar with jekyll/integration-tests... Not sure what its purpose is. |
Its purpose was to be the cucumber tests, and that cucumber would no longer be in this repo. It now runs after every push to master, so I figure validation there would be fine as well. |
@XhmikosR Rebase! |
@parkr: https://ci.appveyor.com/project/jekyll/jekyll/build/56/job/35yd40w77dbl99cw
|
?! I've never seen this before. What version of RubyGems is the machine running? @FeodorFitsner, is there a way to upgrade RubyGems? This version incantation works fine for me. |
@parkr: there is a way but it's uber slow... Let's see. EDIT: Most of the errors (not failures) are due to the yajl-ruby issue. pygments/pygments.rb#106 |
@FeodorFitsner: even with the DNS change, |
@FeodorFitsner: any news? Isn't there something you can do about this? Makes me wonder how no one else has complained about this huge slowdown yet. |
I've been noticing that multiple times too that Let's think on it. I'm going to provision a clean VM on Azure and try reproducing the issue there. So, is it only with Ruby 1.9.3? Maybe @luislavena can suggest something? |
@FeodorFitsner: it's not 1.9.3 only; it happens with every Ruby version only on AppVeyor. On my dev VM everything installs in a timely manner. |
@parkr @alfredxing: now that one build managed to get past the install part, you can see the failures. |
So what are we going to do with this guys? I'm in touch with @FeodorFitsner to fix the speed issues, but until then I have managed to work around it. So, now we see the failures fine. |
@parkr: so any news? Note that it seems there's a new failure due to coffeescript that affects Travis too. |
I'd like to have the appveyor tests passing before merging the branch. Also, 18 minutes is just too long to wait for one build, let alone the potential 72 minute combined build time for all four environments. |
Well caching isn't in effect since tests fail hence the current duration. There is nothing else we can do from our side unfortunately. AppVeyor is
|
:/ |
@parkr: can't GitHub just get a paid plan? Although the first priority should be to just fix the tests and then see how things will go when caching is enabled. I also reduced the configurations tested; I don't see any point in testing all of 2.0-2.2 x64, I only kept one x64. |
[ci skip]
This is needed since older versions choke on the beta version tag used and give the following error: > There was a ArgumentError while loading jekyll.gemspec: > Malformed version number string 3.0.0-beta1 from > C:/projects/jekyll/jekyll.gemspec:13:in `block in <main>' Note that newer Rubygems versions have other various issues on Windows, so v2.3.0 is the only solution at this point.
@parkr: someone seems removed Appveyor from the project. |
What purpose does Appveyor serve for the Jekyll project? |
Well, Jekyll has broken in the past for Windows only and none from the
|
However, based on your past comments (admittedly by simply scanning without full context) it seems this service wants to charge money and you (might) even recommend it which makes this futile. |
Huh? Travis offers pro plans too. I don't care about AppVeyor or anything; it's just what I used. You are free to find any other better solution for Windows. Anyway, I find futile this whole PR from the fact that I have it opened since November 2014. Closing and take care of Windows yourself. |
Fair enough. I hope you enjoy your day and sorry it didn't work out. |
https://ci.appveyor.com/project/jekyll/jekyllhttps://ci.appveyor.com/project/XhmikosR/jekyll
TODO:
jekyll
in https://ci.appveyor.com/accountWe need to make all the tests pass first, in order for this to take effectSee whySee here for a workaroundgem update --system
seems to make the whole process halt